Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-46563

Header diff issues in QtMultimedia

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Done
    • Affects Version/s: 5.5.0 RC
    • Fix Version/s: 5.5.0
    • Component/s: Multimedia
    • Labels:
      None
    • Commits:
      7f9beeaf9c1f86268dee8e6f668fbf78313ffd9c

      Description

      On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote:
      > + typedef QPair<qreal, qreal> FrameRateRange;

      Should be a struct, not a QPair:

      FrameRateChange chg = ...;
      chg.first... // what's first???
      chg.second... // what's second???

      > enum Status {
      > UnavailableStatus,
      > UnloadedStatus,
      > @@ -169,6 +172,21 @@ public:
      > void setViewfinder(QGraphicsVideoItem *viewfinder);
      > void setViewfinder(QAbstractVideoSurface *surface);
      >
      > + QCameraViewfinderSettings viewfinderSettings() const;
      > + void setViewfinderSettings(const QCameraViewfinderSettings &settings);
      > +
      > + QList<QCameraViewfinderSettings> supportedViewfinderSettings(
      > + const QCameraViewfinderSettings &settings =
      > QCameraViewfinderSettings()) const;

      QCameraViewFinderSettings isn't marked as movable, so should be held in
      QVector instead.

      > + QList<QSize> supportedViewfinderResolutions(
      > + const QCameraViewfinderSettings &settings =
      > QCameraViewfinderSettings()) const;

      QList<QSize> should be QVector<QSize>

      > + QList<FrameRateRange> supportedViewfinderFrameRateRanges(
      > + const QCameraViewfinderSettings &settings =

      QList<FrameRateChange> should be QVector<FrameRateChange>

      > QCameraViewfinderSettings()) const; +
      > + QList<QVideoFrame::PixelFormat> supportedViewfinderPixelFormats(
      > + const QCameraViewfinderSettings &settings =
      > QCameraViewfinderSettings()) const;

      QList<PixelFormat> should be QVector<PixelFormat> (enum PixelFormat)

      Thanks,
      Marc


      Marc Mutz <marc.mutz@kdab.com> | Senior Software Engineer

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              ylopes Yoann Lopes
              Reporter:
              janihe Jani Heikkinen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes