Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-46649

MSVC warnings 4718 and 4127 in QMapData

    XMLWordPrintable

Details

    • 307f55129181f67fb99bd9dd38b7017928a0aae1 (qtbase/dev, 16.6.2015, 5.6)

    Description

      Code in QMapData::deleteNode() triggers warning C4127: conditional expression is constant. qmap.h already suppresses this warning for QMapNode::destroySubTree() just before QMapData::deleteNode(), #pragma warning(pop) just needs to be moved one function down.

      destroySubTree() triggers warning 4718 when QMap is used with simple types, like QMap<int, Foo*>:

      warning C4718: 'QMapNode<int,MooEdit * __ptr64>::destroySubTree' : recursive call has no side effects, deleting

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-31516 Windows, MSVC2010+: Warning C4718 with QMap when using /W 4

          • P4: Low - Would be nice to fix, but it's not very important.
          • Closed
          replaces

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-54089 MSVC warnings 4718 in QMapData

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed
          For Gerrit Dashboard: QTBUG-46649
          # Subject Branch Project Status CR V
          114340,1 Disable more warnings from MSVC in qmap.h 5.5 qt/qtbase Status: ABANDONED 0 0
          114431,3 QMap: use constrained templates instead of static-ifs dev qt/qtbase Status: MERGED +2 0

          Activity

            People

              thiago Thiago Macieira
              muntyan Yevgen Muntyan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes