Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-46679

[REG 5.4 -> 5.5.0beta] QMake Visual Studio generator - wrong option value for precompiled header

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 5.5.0
    • 5.5.0 Beta
    • Build tools: qmake
    • None
    • 059e1df345bab5754488a63e6d149de86ebf655a

    Description

      1. Create project with PRECOMPILED_HEADER=../some_path/header.h
      2. Generate MS VC Solution

      Building the project fails with the following error message:

      error C2857: '#include' statement specified with the /Yc..\some_path\header.h command-line option was not found in the source file

      header.h.cpp is created in ../some_path and contains the include "header.h".
      The generated options for header.h.cpp is 

      /Yc"../_some_path_/header.h".

      it should be

       /Yc"header.h"

      Change dc612acdc6577594c8f61345cea2de549d7aae34 (https://codereview.qt-project.org/#/c/96979/) seems to have introduced this regression.

      Attachments

        Issue Links

          is required for

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-46579 Issues to be fixed before Qt 5.5.0 Final release

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          resulted from

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-41917 Precompiled header generation for Visual studio

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          For Gerrit Dashboard: QTBUG-46679
          # Subject Branch Project Status CR V
          114449,3 fix PCH related regression in vcxproj generator 5.5.0 qt/qtbase Status: MERGED +2 0

          Activity

            People

              jbornema Joerg Bornemann
              sh_viktor Viktor Shanin
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes