Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-47775

qmake generate wrong code for Info.plist in unixmakefile2 if bundle path has spaces

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.5.0
    • Fix Version/s: 5.5.1
    • Component/s: Build tools: qmake
    • Labels:
      None
    • Commits:
      f5885f71fd80bd1953c3be5e48dd1ad4fb1af9a1

      Description

      When generating Makefile code for Info.plist on MAC, qmake does not resolve spaces in the bundle path when checking and creating path to Info.plist

      Example Makefile:

      ...
      ../my_repo/My\ app.app/Contents/Info.plist:
          @test -d ../my_repo/My app.app/Contents/Info.plist || mkdir -p ../my_repo/My\ app.app/Contents/Info.plist
      ...
      

      Check that in "test -d" dir name is not escape quoted.

      The problem is in this line of code:

        t << mkdir_p_asstring(destdir, false) << "\n\t";
      

      It should be:

        t << mkdir_p_asstring(destdir) << "\n\t";
      

      or:

        t << mkdir_p_asstring(destdir, true) << "\n\t";
      

        Attachments

        For Gerrit Dashboard: QTBUG-47775
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            buddenha Oswald Buddenhagen
            Reporter:
            Youw Ihor Dutchak
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes