Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-49081

Out-of-source build's make check taints the source tree

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P4: Low
    • 5.12.3
    • 5.6.0 Alpha
    • Build System, Other
    • GNU/Linux, Debian/testing, x86_64.
    • 04def3a8786c59a1161df3a10d966311ae9fef2d 2abd969ef6f5841526c48da2e54fe47a001e8d69

    Description

      I build outside my source tree (i.e. pick a build directory elsewhere and run path/to/source/configure instead of ./configure).
      When I do a full make check (i.e. in the build's top level) I have a few failures (possibly from local oddities of my system, I don't know) and a subsequent git status in the source tree's qtbase/ reveals:

      	tests/auto/tools/qmake/testdata/pro_file_cache/include.pri
      	tests/auto/tools/qmake/testdata/quotedfilenames/cpp folder/
      	tests/auto/tools/qmake/testdata/quotedfilenames/quotedfilenames
      	tests/auto/tools/qmake/testdata/resources/resources
      	tests/auto/widgets/util/qundogroup/testdata/qundogroup.qm
      	tests/auto/widgets/util/qundostack/testdata/qundostack.qm
      

      An out-of-source build should not mess with the source tree.
      Tests should put the files they generate in the tree where they are run, not the source tree.
      If anything in build and test really does need to drop files in the source tree, it should be mentioned in a suitable .gitignore file.

      The last but one file above is likely accounted for by:

      make[6]: Entering directory '[build]/qt5/qtbase/tests/auto/widgets/util/qundogroup'
      QT_PLUGIN_PATH=[build]/qt5/qtbase/plugins LD_LIBRARY_PATH=[build]/qt5/qtbase/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}  ./tst_qundogroup 
      ********* Start testing of tst_QUndoGroup *********
      Config: Using QtTest library 5.6.0, Qt 5.6.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 5.2.1 20151010)
      PASS   : tst_QUndoGroup::initTestCase()
      PASS   : tst_QUndoGroup::setActive()
      PASS   : tst_QUndoGroup::addRemoveStack()
      PASS   : tst_QUndoGroup::deleteStack()
      PASS   : tst_QUndoGroup::checkSignals()
      PASS   : tst_QUndoGroup::addStackAndDie()
      lrelease version 5.6.0
      Updating '[src]/qt5/qtbase/tests/auto/widgets/util/qundogroup/testdata/qundogroup.qm'...
          Generated 4 translation(s) (4 finished and 0 unfinished)
      PASS   : tst_QUndoGroup::commandTextFormat()
      PASS   : tst_QUndoGroup::cleanupTestCase()
      Totals: 8 passed, 0 failed, 0 skipped, 0 blacklisted
      ********* Finished testing of tst_QUndoGroup *********
      make[6]: Leaving directory [build]/qt5/qtbase/tests/auto/widgets/util/qundogroup'
      

      Attachments

        Issue Links

          For Gerrit Dashboard: QTBUG-49081
          # Subject Branch Project Status CR V

          Activity

            People

              Unassigned Unassigned
              Eddy Edward Welbourne
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes