Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-49241

Should not close windows after emitting commitDataRequest()

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • P2: Important
    • None
    • 5.5.1
    • QPA: X11/XCB
    • None
    • x86_64-pc-linux-gnu
      linux-4.3.0, gcc-5.2.0, glibc-2.22, binutils-2.25.1, Qt-5.5.1, mesa.11.0.3,
      KDE (plasma-5.4.2, frameworks-5.15.0, applications-15.08.2)

    Description

      Doing window closures here means that clients die before the session and window managers, e.g., KDE ksmserver and kwin_x11, are unable to include them in their saved states, breaking session management (see for example, https://bugs.kde.org/show_bug.cgi?id=346768).

      It would seem more appropriate to not worry about session cancellation here, allowing clients to do this is their commitData() slots.

      The attached patch, plus some minor patching in KDE5's kxmlgui and plasma-workspace, at least in my testing, allows KDE5 session management to work as expected.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              paeglis Gatis Paeglis
              jpsinthemix John Stanley
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes