Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-49882

407 proxy authentication failure not reported with NTML proxy

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reported
    • Priority: P2: Important
    • Resolution: Unresolved
    • Affects Version/s: 5.5.0
    • Fix Version/s: None
    • Labels:
      None

      Description

      When HTTPS and NTML proxy are utilised the 407 proxy authentication failure isn't reporter via QNetworkReply or QNetworkAccessManager signalling. Instead QHttpSocketEngine keeps connecting with erroneous credentials for good. Also QNetworkReply::abort doesn't work in this situation. Note that with HTTP the issue doesn't exist.

      The following patch partly fixes this (at least error gets reported), not sure if something else needs to be taken into account?:

      +diff --git a/src/network/socket/qhttpsocketengine.cpp b/src/network/socket/qhttpsocketengine.cpp
      +index 23347ce..b92db38 100644
      +--- a/src/network/socket/qhttpsocketengine.cpp
      ++++ b/src/network/socket/qhttpsocketengine.cpp
      +@@ -589,7 +589,7 @@ void QHttpSocketEngine::slotSocketReadNotification()
      +
      + priv->parseHttpResponse(d->reply->header(), true);
      +
      +- if (priv->phase == QAuthenticatorPrivate::Invalid) {
      ++ if (priv->phase == QAuthenticatorPrivate::Invalid || priv->hasFailed) {
      + // problem parsing the reply
      + d->socket->close();
      + setState(QAbstractSocket::UnconnectedState);

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              thiago Thiago Macieira
              Reporter:
              jtykka Jani Tykkä
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Gerrit Reviews

                There are no open Gerrit changes