Details
-
Task
-
Resolution: Done
-
P2: Important
-
None
-
None
-
a40591931dd372829982055d4000c5caf3df9d07 a9735e783761cc2f98001cb72e6aa37315b1af70
Description
QQuickPopup is a QObject, not a QQuickControl, so it doesn't inherit fonts correctly. We need to make QQuickPopup::popupItem() inherit its font from QQuickPopup::parentItem().
A test case with ComboBox:
import QtQuick 2.3 import Qt.labs.controls 1.0 ApplicationWindow { id: window width: 400 height: 600 visible: true font.family: "Courier" Pane { anchors.centerIn: parent anchors.verticalCenterOffset: -height font.pixelSize: 30 Column { spacing: 20 Button { text: "Button" } ComboBox { model: ["ComboBox", "With", "Plenty", "Of", "Items"] } } } }
Attachments
Issue Links
- resulted in
-
QTBUG-51696 Font propagation broke theme style
- Closed
For Gerrit Dashboard: QTBUG-50984 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
148971,7 | Controls: fix font inheritance for popups | 5.6 | qt/qtquickcontrols2 | Status: MERGED | -2 | 0 |
149887,5 | Controls: fix locale inheritance for popups | 5.6 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
151799,2 | QQuickPopup: add font property | 5.6 | qt/qtquickcontrols2 | Status: ABANDONED | 0 | 0 |
151800,1 | WIP: QQuickPopup: add locale property | 5.6 | qt/qtquickcontrols2 | Status: ABANDONED | -2 | 0 |
151850,1 | QQuickPopup: add font property | 5.6 | qt/qtquickcontrols2 | Status: ABANDONED | 0 | 0 |
151944,4 | Revert "QQuickControl: delayed the call of resolveFont()" | 5.6 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
151985,4 | Fix font comparisons | 5.6 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
151989,1 | tst_combobox: temporarily comment popup font tests | 5.6 | qt/qtquickcontrols2 | Status: ABANDONED | 0 | 0 |
151997,3 | Fix popup fonts | 5.6 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
152002,3 | Test Material fonts | 5.6 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
152088,2 | Test Universal fonts | 5.6 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
152288,2 | QQuickControlPrivate::themeFont(): clear system font's explicit attrs | 5.6 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
152289,2 | Store explicit and resolved font separately | 5.6 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
152479,5 | Change locale inheritance for popups | 5.6 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
153186,2 | Add virtual QQuickControl::fontChange() | 5.7 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
153187,5 | Add Popup::font | 5.7 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
153188,4 | Add Popup::locale | 5.7 | qt/qtquickcontrols2 | Status: MERGED | -2 | 0 |