Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-51057

Wrong MacOS colormanagement handling

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 5.12.5
    • 5.5.0, 5.5.1, 5.6.0 Beta
    • QPA
    • None
    • MacOS
    • macOS

    Description

      Qt applications handle ColorSync color management wrongly and this create real problems to color sensitive applications.

      Let me show problem on example.
      1. we start qt creator (as example of qt app) - "Screen Shot1"
      2. change display profile to fakebgr (attached - well visible changes) - "Screen Shot2"
      As you see macos elements changes colors to false colors, but qt creators stays with the same colors.

      Problem that in cocoa realisation you give to all widgets display profile as internal color space. This is not correct approach. Display profile is output colorspace. And we need to use system colorspace as widgets colorspace.

      I attach minimalistic patch that fix this problem. For sure if Qt team will agree to change cocoa plugin this way then a lot of code should be removed as unnecessary, so source changes will be bigger.

      P.S. same mistake code exists in qpaintengine_mac.mm, but seems it influence on nothing. Is it junk?

      Attachments

        1. cocoa_colorsync.patch
          0.7 kB
          Vitaly
        2. FakeBRG_swop colors.icc
          0.8 kB
          Vitaly
        3. Screen Shot1.png
          483 kB
          Vitaly
        4. Screen Shot2.png
          520 kB
          Vitaly

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              vestbo Tor Arne Vestbø
              johngull Vitaly
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes