Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-51602

Don't generate code using QStringLiteral as this can create a problem if the code is used in a DLL

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3: Somewhat important
    • Resolution: Done
    • Affects Version/s: 5.5.1
    • Fix Version/s: 5.12.0 Alpha
    • Component/s: Build tools: uic
    • Labels:
      None
    • Commits:
      ff18b02f21a04f7092b58be04be5a40df3ef993b

      Description

      Don't generate code using QStringLiteral as this can create a problem if the code is used in a DLL. Since the code is generated by uic then it should not be using QStringLiteral as it is not known where the generate code will end up, if it is in a user created dll then it can cause a crash when being unloaded due to the fact that QStringLiteral expects to be valid the whole time.

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-62625 App crashes on termination if a font is loaded by unloaded library

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-65251 uic generates QLatin1String for shortcuts

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          replaces

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-46880 QFontCache crash when DLL is unloaded

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          For Gerrit Dashboard: QTBUG-51602
          # Subject Branch Project Status CR V
          201309,3 uic: Add -no-stringliteral option dev qt/qtbase Status: MERGED +2 0
          234503,8 uic: Revert the microoptimization patch introducing QStringLiteral dev qt/qtbase Status: MERGED +2 0

            Activity

              People

              Assignee:
              jkobus Jarek Kobus
              Reporter:
              andysh Andy Shaw
              Votes:
              3 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes