Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-53721

[REG 5.2 -> 5.3] QImage's move semantics versions of rgbSwapped() and mirrored() methods break backwards compatibility

    XMLWordPrintable

Details

    Description

      When creating code that will call move semantics versions of QImage::rgbSwapped() and QImage::mirrored(), it will break backwards compatibility between 5.2 and 5.3. The move semantics version of these methods are not documented at all.

      Steps to reproduce:

      • Run attached sample
      • EXPECTED: No problems are detected
      • ACTUAL: rgbSwapped() and mirrored() methods will access the temporary QImage buffers directly, which will cause program to later access memory that is already released.

      This problem is most easily detected with Visual Studio, debug build. Also Valgrind will detect the invalid memory access.

      Attachments

        1. qtbug53721_valgrind.txt
          99 kB
          Friedemann Kleint
        2. qtbug53721.zip
          30 kB
          Friedemann Kleint
        3. qtbug53721.zip
          30 kB
          Jussi Witick

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-44610 Windows: Crash in qimage_conversions -> convert_RGB_to_RGB16_inplace

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-44706 [REG 5.4->5.5] g++ compiler: QString::simplified() clobbers input

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-18519 QPixmap in QPixmapCache gets changed when using QPixmap::convertFromImage

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-53721
          # Subject Branch Project Status CR V
          161720,3 Finally fix crash in inplace-modified data-constructed images 5.6 qt/qtbase Status: MERGED -2 0

          Activity

            People

              vgt Eirik Aavitsland
              jussi_witick Jussi Witick
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes