Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-54380

[macOS] macdeployqt crashes when code signing

    XMLWordPrintable

Details

    • macOS
    • 335d91e6d6c4ac21bcf39c4f5bb9a8bcd0e597bf

    Description

      When macdeployqt is invoked with the codesign option it segfaults. I traced the problem to the function codeSignBundle which calls findAppBundleFiles to get a list of binary files within a bundle. The trouble is, this function returns all the files in the bundle, not just the binaries. In particular it returns plist files, which then get passed to getBinaryDependencies and subsequently findDependencyInfo. In this function otool is invoked on the plist file and a crash occurs when its output is parsed.

      Attached is a fix I have applied which checks if the files findAppBundleFiles returns are binaries before passing them on further. It is perhaps not the most elegant fix ever, but it does the job of getting our CI builds going again.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            sorvig Morten Sørvig
            timangus Tim Angus
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes