Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-54732

Item change listener loops break on listener removal

    XMLWordPrintable

Details

    • 35d500526990fafe5b71d97b051a770a2a81e82a

    Description

      All listeners should get invoked, even if they remove themselves while iterating the listeners. An index-based loop would skip the next listener in the list, and an iterator-based or range for loop ends up with invalid iterators unless it makes a (cheap) copy before iterating the listeners.

      The listeners were fixed in https://codereview.qt-project.org/#/c/159505/ but https://codereview.qt-project.org/#/c/155386/ reintroduced the issue for itemGeometryChanged().

      Attachments

        Issue Links

          replaces

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-53453 Regression: Pushing item with two drawers into StackView crashes in QQuickItemPrivate::itemChange()

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          resulted from

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-54727 Tumbler: destroyed item change listeners notified

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-54732
          # Subject Branch Project Status CR V
          165038,3 Fix itemGeometryChanged() listeners dev qt/qtdeclarative Status: MERGED +2 0

          Activity

            People

              Unassigned Unassigned
              jpnurmi J-P Nurmi
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes