Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-54805

Glow effect radius shouldn't need scaling by devicePixelRatio to get the same apparance on retina devices

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3: Somewhat important
    • None
    • 5.6.1
    • mid-2012Mac, various Linux machines, a "retina" iPad. Qt5.6.1 downloaded by Qt MaintainanceTool

    Description

      I've recently been revisiting some old code last built with earlier Qt5 releases and updating it to Qt5.6.1 (not sure exactly which version of Qt5.x I was updating from, but it was before a version or two where the Glow effect was significantly overhauled but broken for a while; see QTBUG-47448)

      Anyway, I've been a bit surprised to find that after the update, some Glow effects looked significantly different on OSX (&Linux) and iOS.

      In all cases I was using a Glow with radius of 16 and samples 32, but on iOS the glow looked much "thinner". I was able to fix this by exposing devicePixelRatio to my QML and multiplying the radius up by that, after which things look much more similar.

      I'd expect radius to be defined in "logical" pixels, like most everything else in QML... but what I'm seeing seems to imply it's defined in device pixels.

      I'll add some screenshots at some point.

      Attachments

        1. butterfly.png
          butterfly.png
          36 kB
        2. glow.qml
          0.4 kB
        3. ios.png
          ios.png
          182 kB
        4. ios-extract_and_shrink.png
          ios-extract_and_shrink.png
          10 kB
        5. ios-glow-globe-aware.png
          ios-glow-globe-aware.png
          549 kB
        6. ios-glow-globe-ignorant.png
          ios-glow-globe-ignorant.png
          557 kB
        7. ios-glow-icon-aware.png
          ios-glow-icon-aware.png
          554 kB
        8. ios-glow-icon-aware-extract.png
          ios-glow-icon-aware-extract.png
          8 kB
        9. ios-glow-icon-ignorant.png
          ios-glow-icon-ignorant.png
          529 kB
        10. ios-glow-icon-ignorant-extract.png
          ios-glow-icon-ignorant-extract.png
          6 kB
        11. linux.png
          linux.png
          39 kB
        12. linux-extract.png
          linux-extract.png
          9 kB
        13. linux-glow-icon-extract.png
          linux-glow-icon-extract.png
          6 kB
        14. mac.png
          mac.png
          79 kB
        15. mac-extract.png
          mac-extract.png
          10 kB
        16. mac-glow-globe.png
          mac-glow-globe.png
          282 kB
        17. mac-glow-icon.png
          mac-glow-icon.png
          283 kB
        18. mac-glow-icon-extract.png
          mac-glow-icon-extract.png
          17 kB
        19. qtbug54805.zip
          36 kB
        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qt.team.graphics.and.multimedia Qt Graphics Team
            timday Tim Day
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes