Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-54998

tslib incorrectly depends on evdev

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.5.0, 5.6.0
    • Fix Version/s: 5.6.3
    • Component/s: QPA: EGLFS
    • Labels:
      None
    • Commits:
      5fcda458721c85f7b4209f418b416ffa5c93936e

      Description

      qeglfsintegration.cpp includes the following block:

      #if !defined(QT_NO_EVDEV) && !defined(Q_OS_ANDROID)
          m_kbdMgr = new QEvdevKeyboardManager(QLatin1String("EvdevKeyboard"), QString() /* spec */, this);
          new QEvdevMouseManager(QLatin1String("EvdevMouse"), QString() /* spec */, this);
      #ifndef QT_NO_TSLIB
          const bool useTslib = qEnvironmentVariableIntValue("QT_QPA_EGLFS_TSLIB");
          if (useTslib)
              new QTsLibMouseHandler(QLatin1String("TsLib"), QString() /* spec */);
          else
      #endif // QT_NO_TSLIB
              new QEvdevTouchManager(QLatin1String("EvdevTouch"), QString() /* spec */, this);
      #endif
      

      The ifdef for tslib is within the ifdef for evdev, which seems problematic (e.g. configuring with -tslib -no-evdev seems like it would fail to be able to create the tslib plugin)

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            lagocs Laszlo Agocs
            Reporter:
            mbrasser Michael Brasser
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes