-
Bug
-
Resolution: Done
-
P2: Important
-
5.7.0
-
None
When building this module there are slots of warnings regarding headers coding style:
Project MESSAGE: perl -w /home/rkeller/dev/qt/qt5.8/qt5/qtbase/bin/syncqt.pl -check-includes -module QtNetworkSettings -version 1.0 -outdir /home/rkeller/dev/qt/qt5.8/build/qtbase /home/rkeller/bosch/druckmesswt/qtdeviceutilities <srcbase> = /home/rkeller/bosch/druckmesswt/qtdeviceutilities <outbase> = /home/rkeller/dev/qt/qt5.8/build/qtbase QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettings.h includes qnetworksettingsaddressmodel.h when it should include QtNetworkSettings/qnetworksettingsaddressmodel.h QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettings.h does not include QT_BEGIN_NAMESPACE QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsaddressmodel.h does not include QT_BEGIN_NAMESPACE QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsinterface.h includes qnetworksettings.h when it should include QtNetworkSettings/qnetworksettings.h QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsinterface.h does not include QT_BEGIN_NAMESPACE QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsinterfacemodel.h includes qnetworksettings.h when it should include QtNetworkSettings/qnetworksettings.h QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsinterfacemodel.h does not include QT_BEGIN_NAMESPACE QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsmanager.h includes qnetworksettings.h when it should include QtNetworkSettings/qnetworksettings.h QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsmanager.h does not include QT_BEGIN_NAMESPACE QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsservice.h includes qnetworksettings.h when it should include QtNetworkSettings/qnetworksettings.h QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsservice.h does not include QT_BEGIN_NAMESPACE QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsservicemodel.h includes qnetworksettings.h when it should include QtNetworkSettings/qnetworksettings.h QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsservicemodel.h includes qnetworksettingsservice.h when it should include QtNetworkSettings/qnetworksettingsservice.h QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsservicemodel.h does not include QT_BEGIN_NAMESPACE QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/qnetworksettingsuseragent.h does not include QT_BEGIN_NAMESPACE QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/connman/connmancommon.h includes qnetworksettings.h when it should include QtNetworkSettings/qnetworksettings.h QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/connman/connmancommon.h does not include QT_BEGIN_NAMESPACE QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/connman/qnetworksettingsinterface_p.h does not have the "We mean it." warning QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/connman/qnetworksettingsmanager_p.h does not have the "We mean it." warning QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/connman/qnetworksettingsservice_p.h does not have the "We mean it." warning QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/connman/qnetworksettingsuseragent_p.h does not have the "We mean it." warning QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/wpasupplicant/qnetworksettingsinterface_p.h does not have the "We mean it." warning QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/wpasupplicant/qnetworksettingsmanager_p.h does not have the "We mean it." warning QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/wpasupplicant/qnetworksettingsservice_p.h does not have the "We mean it." warning QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/wpasupplicant/qnetworksettingsuseragent_p.h does not have the "We mean it." warning QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/wpasupplicant/qwificontroller_p.h does not have the "We mean it." warning QtNetworkSettings: WARNING: /home/rkeller/bosch/druckmesswt/qtdeviceutilities/src/networksettings/wpasupplicant/qwifisupplicant_p.h does not have the "We mean it." warning Use of uninitialized value in sprintf at /home/rkeller/dev/qt/qt5.8/qt5/qtbase/bin/syncqt.pl line 1225.
Only half of those is critical but all of them should be fixed.
Additionally there are lots of headers missing after building and headers don't have the common Qt naming.