Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-56805

QWebEnginePage::acceptNavigationRequest always has type==NavigationTypeLinkClicked

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • P2: Important
    • 5.12.3
    • 5.11
    • WebEngine
    • None
    • Qt 5.8 from git
      QtWebEngine 4d56afd

    Description

      When doing Ctrl+click on a link or using javascript window.open, createWindow() is called, followed by acceptNavigationRequest() on the new page. In a web browser (konqueror) we need to be able to differenciate between the two use cases, e.g. to implement things like a confirmation messagebox ("this website wants to open a popup, accept/deny?").

      With QtWebkit we used the NavigationType enum passed to acceptNavigationRequest(), if it was NavigationTypeLinkClicked it was a user action (no confirmation), if it was NavigationTypeOther it was triggered by javascript.

      With QtWebEngine the API looks the same, but the type enum is always NavigationTypeLinkClicked, it seems.

      Testcase:

        <a href="javascript:setTimeout(window.open('http://www.davidfaure.fr'), 3000)">window.open delayed</a>

      QtWebKit says:

      NewWindowPage::acceptNavigationRequest: url: QUrl("http://www.davidfaure.fr/") ,type: 5 (NavigationTypeOther)

      QtWebEngine says:

      NewWindowPage::acceptNavigationRequest: url: QUrl("http://www.davidfaure.fr/") , type: 0 (NavigationTypeLinkClicked)

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-74490 Wrong NavigationType for http-equiv=REFRESH

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-50672 QWebEnginePage::acceptNavigationRequest() is called with type NavigationTypeLinkClicked even when no links have been clicked

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-63265 When reimplement acceptNavigationRequest a url with NavigationTypeLinkClicked is passed in after a page has finished loading

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-52239 QWebEngineUrlRequestInterceptor::interceptRequest invalid type returned by QWebEngineUrlRequestInfo::navigationType()

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              allan.jensen Allan Sandfeld Jensen
              dfaure_kdab David Faure
              Votes:
              8 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes