Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-59723

-developer-build broken with disabled features due to the -Werror and unused variables/parameters

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3: Somewhat important
    • Resolution: Done
    • Affects Version/s: 5.9.0 Alpha
    • Fix Version/s: 5.9.0
    • Labels:
      None
    • Environment:
      Mageia Linux Cauldron x86_64, GCC 5.4.0

      Description

      As Qt Light allow to disable some components, I tried the following config:

      ~/Development/qt5/qtbase/configure -prefix ~/Development/qt5.9_git -developer-build -opensource -confirm-license -no-pch -skip qtwebkit -skip qtwebkit-examples -skip qt3d -skip qtxmlpatterns -skip qtwayland -skip qtwebengine -skip qtwebview -skip qtmultimedia -skip qtlocation -skip qtcanvas3d -skip qtwebsockets -skip qtwebchannel -skip qtenginio -skip qtsensors -skip qtserialport -skip qtpurchasing -skip qtquick1 -skip qtscript -skip qtconnectivity -skip qtcharts -skip qtdatavis3d -skip qtgamepad -skip qtvirtualkeyboard -skip qtscxml -skip qtremoteobjects -skip qtspeech -skip qtnetworkauth -no-feature-bearermanagement -no-feature-colordialog -no-feature-columnview -no-feature-commandlinkbutton -no-feature-cssparser -no-feature-cups -no-feature-datawidgetmapper -no-feature-dial -no-feature-dockwidget -no-feature-fontdialog -no-feature-ftp -no-feature-imageformat_bmp -no-feature-itemviews -no-feature-lcdnumber -no-feature-listview -no-feature-listwidget -no-feature-mdiarea -no-feature-mimetype -no-feature-movie -no-feature-pdf -no-feature-printdialog -no-feature-printer -no-feature-printpreviewdialog -no-feature-printpreviewwidget -no-feature-qml-network -no-feature-quick-designer -no-feature-quick-flipable -no-feature-quickcontrols2-universal -no-feature-tableview -no-feature-tablewidget -no-feature-textodfwriter -no-feature-treeview -no-feature-treewidget -no-feature-undocommand -no-feature-undogroup -no-feature-undostack -no-feature-undoview -no-feature-wizard -no-feature-xmlstreamwriter -nomake examples -nomake tests

      It results in a multiple failures, because warnings treated as errors and there are some unused variables and parameters.

      Either -developer-build shouldn't be combined with the -no-feature or all this variables should be properly placed in the #ifdef and unused parameter should has Q_UNUSED.

      I made several patches to fix the issues, but there may be more:
      https://codereview.qt-project.org/189456
      https://codereview.qt-project.org/189455
      https://codereview.qt-project.org/189454
      https://codereview.qt-project.org/189453
      https://codereview.qt-project.org/189452
      https://codereview.qt-project.org/189451
      https://codereview.qt-project.org/189459

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              krnekit Nikita Krupenko
              Reporter:
              krnekit Nikita Krupenko
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes