Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-60179

Energy conservation and/or specular term broken in PBR shaders

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Done
    • Affects Version/s: 5.9.0 Beta 1
    • Fix Version/s: 5.9.0 Beta 2
    • Component/s: Qt3D
    • Labels:
      None
    • Commits:
      dfdf17a19d0c516757ba7a0833b267d40d52b9ae

      Description

      Even when using diffuse materials (like in https://www.kdab.com/qt-3d-animation-easter-teaser/) there is still a strong (and clamped) specular component at grazing angles such as on the silhouette edge of the egg.

      This seems to be because the geometric factor is hard-wired to 1. Really even for an implicit geometric term it should be set to the same value as the denominator otherwise at grazing angles the vDotN factor gets very small in the denominator making the specular term blow up.

        Attachments

        For Gerrit Dashboard: QTBUG-60179
        # Subject Branch Project Status CR V

          Activity

            People

            • Assignee:
              seanharmer Sean Harmer
              Reporter:
              seanharmer Sean Harmer
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes