Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-61299

Demobrowser doesn't compile anymore

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 5.9.1
    • 5.9
    • WebEngine
    • None
    • Archlinux, GCC 7.1.1 20170516

    Description

      https://codereview.qt-project.org/#/c/195836/ from michal doesn't seem to compile:

       

      browserapplication.cpp: In member function 'void BrowserApplication::quitBrowser()':
browserapplication.cpp:235:5: error: 'close' was not declared in this scope
close();
^~~~~
browserapplication.cpp:235:5: note: suggested alternative: 'pclose'
close();
^~~~~
pclose
make: *** [Makefile:8968: .obj/browserapplication.o] Error 1

      Attachments

        Issue Links

          resulted in

          Task - A task that needs to be done. COIN-206 Build WebEngine examples with MSVC2015

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-61299
          # Subject Branch Project Status CR V
          196763,2 Revert "Fix flushing the cookies with demobrowser" 5.9 qt/qtwebengine Status: MERGED +2 0

          Activity

            People

              michal Michal Klocek
              the compiler Florian Bruhin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes