Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-61491

QGnomeTheme text for QMessageBox::Discard shall not use "Close"

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • 5.6.2, 5.9.0
    • None
    • Ubuntu 16.04, individual Qt.

    Description

      I just stumbled over the fact that in some contexts, the QMessageBox::Discard button is labeled "Close without Saving". I discovered that this wording comes from QGnomeTheme in src/platformsupport/themes/genericunix/qgenericunixthemes.cpp.

      Documentation says that I can expect a "A "Discard" or "Don't Save" button, depending on the platform, defined with the DestructiveRole.". There is no mention of "closing". It may have such uses, such as closing a file in an editor window. But the documentation doesn't keep anyone from using Discard in other contexts, such as dealing with intermediate results in an ongoing activity. "Close without Saving" looks strange then.

      Either the documentation should give a better warning, or the text should be changed.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qt.team.quick.subscriptions Qt Quick and Widgets Team
            dg0yt Kai Pastor
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes