Details
-
Bug
-
Resolution: Out of scope
-
Not Evaluated
-
None
-
5.7.1, 5.9.0
-
None
-
Cross compiling x86_64-w64-mingw32 with gcc 7.1.0
Description
Some of the -no-feature flags will break the Windows build due to qconfig.h being included after the #ifndef check. Tested on 5.7.1 and 5.9.0.
While I don't have an exhaustive list, here are a few I encountered while I was trying to build Qt:
- qwizard_win.cpp: https://github.com/qt/qtbase/blob/v5.9.0/src/widgets/dialogs/qwizard_win.cpp#L40-L42
- Some of the qprinter/qprintdialog stuff was failing on 5.7.1, but that seems to have been (mostly) fixed by 5.9 (there are some other mostly unrelated issues now if you try to disable it)
Just swapping the #ifndef and the first include seems to fix the issue. There could well be more of these lurking around though.