Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-62680

it seems like commit a576954f9b96d2777d8cce09be31eb3f62e0e882 has introduced a new bug

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 5.9.3
    • 5.9.0, 5.9.1
    • Core: Plugins
    • None
    • ALL
    • 37afba28b152b9c5cb1dfaa9a89df1e8103cde26

    Description

      it seems like commit a576954f9b96d2777d8cce09be31eb3f62e0e882 has introduce a new bug

      this commit is not release yet, it is qt 5.9 branch

      int fromBase8(const char* s, const char* end) {
          int result = 0;
          while (*s && s != end) {
      -        if (*s <= '0' && *s >= '7')
      +        if (*s <= '0' || *s >= '7')
                  return 0;
              result *= 8;
              result += *s - '0';
              ++s;
          }
          return result;
      }
      

      it should be

      int fromBase8(const char* s, const char* end) {
          int result = 0;
          while (*s && s != end) {
              if (*s < '0' || *s > '7')  /// HERE, NO EUQAL
                  return 0;
              result *= 8;
              result += *s - '0';
              ++s;
          }
          return result;
      }
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            laknoll Lars Knoll
            dext dexter
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes