Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-63099

QFile::seek() on character devices not working

    XMLWordPrintable

Details

    • Bug
    • Resolution: Incomplete
    • P3: Somewhat important
    • None
    • 5.6.0
    • Core: I/O
    • None

    Description

      There is a very subtle bug in the QFileDevice::seek() call.

      Consider this if:

      if (!d->fileEngine->seek(off) || !QIODevice::seek(off)) {

      If d->fileEngine->seek succeeded there is no point to call QIODevice::seek. Most probably it should be changed into a:

      if (!d->fileEngine->seek(off) && !QIODevice::seek(off)) {

      This means if both failed then please bail out.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            thiago Thiago Macieira
            mdw Matthias Wallnoefer
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes