Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-63416

qmlimportscanner always outputs emplty list

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Not Evaluated
    • Resolution: Done
    • Affects Version/s: 5.9.2
    • Fix Version/s: 5.9.2
    • Labels:
      None
    • Environment:
      Windows 10.0.15063

      MSVS 2015 Update 3

      Description

      The following commit breaks qmlimportscanner:

       

      https://code.qt.io/qt/qtdeclarative.git

      Revision: 6ff0e9a65657e8c51a37e63efe8169bb7e3050cc
      Author: Andy Shaw <andy.shaw@qt.io>
      Date: 20.07.2017 20:02:50
      Message:
      qmlimportscanner: Only skip debug/release directories if the path ends with them

      Since the preceding path may contain debug or release in it, then we
      only want to check if the path ends with it as opposed to containing it.

      Change-Id: Ib4d466987fccb75771fcd2fa018b6f1375df7dc4
      Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
      Reviewed-by: Marco Benelli <marco.benelli@qt.io>


      Modified: tools/qmlimportscanner/main.cpp

       

      When reverting the line #407 all works OK:

       

      --- a/tools/qmlimportscanner/main.cpp
      +++ b/tools/qmlimportscanner/main.cpp
      @@ -404,7 +404,7 @@ QVariantList findQmlImportsInDirectory(const QString &qmlDir)
           if (qmlDir.isEmpty())
               return ret;
       
      -    QDirIterator iterator(qmlDir, QDir::AllDirs | QDir::NoDotDot, QDirIterator::Subdirectories);
      +    QDirIterator iterator(qmlDir, QDir::AllDirs | QDir::NoDot | QDir::NoDotDot, QDirIterator::Subdirectories);
           QStringList blacklist;
       
           while (iterator.hasNext()) {

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              andysh Andy Shaw
              Reporter:
              dmitry.sokolov Dmitry Sokolov
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes