Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-63854

Unchecked render_view() in RenderViewObserverHelper class

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3: Somewhat important
    • Resolution: Done
    • Affects Version/s: 5.9.1, 5.9.2
    • Fix Version/s: 5.9.3, 5.10.0
    • Component/s: WebEngine
    • Labels:
      None
    • Environment:
      W10 64 Bit VS 2015 32 Bit compilation

      Description

      In qtwebengine/src/core/renderer/user_resource_controller.cpp all usages of render_view() are unchecked and can be confused with globalScriptsIndex, which is always 0.
      In the class description of RenderViewObserver it says:

        // A subclass can use this to delete itself. If it does not, the subclass must
        // always null-check each call to render_view() becase the RenderView can
        // go away at any time.
      

      -> All return values of render_view() need to be checked against 0. I attached a patch for the Qt 5.9.1 source.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            allan.jensen Allan Sandfeld Jensen
            Reporter:
            salbrecht Samuel Albrecht
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes