Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-65456

QWE doesn't find installed snappy, zlib(minizip) files

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • 5.10
    • 5.9.3
    • WebEngine
    • None
    • Linux

    Description

       

      This looks like a bug to me:

       

      > qmake PREFIX=/opt/local CONFIG+=release -Wall ../qt-everywhere-opensource-src-5.9.3/qtwebengine/qtwebengine.pro QMAKE_LINK=/usr/bin/c++ QT_BUILD_PARTS-="examples" WEBENGINE_CONFIG+=use_proprietary_codecs WEBENGINE_CONFIG+=reduce_binary_size WEBENGINE_CONFIG+=use_system_snappy WEBENGINE_CONFIG+=use_system_ffmpeg WEBENGINE_CONFIG+=use_native_
      spellchecker WEBENGINE_CONFIG+=use_system_opus -spec linux-g++-64
      [SNIP
      Checking for snappy... no
      Checking for winversion... no
      System libxml2 is not configured with ICU. Using Chromium's copy.
      System libevent not found. Using Chromium's copy.
      Compatible system libvpx not found. Using Chromium's copy.
      System snappy not found. Using Chromium's copy.
      System library dependencies:
      Optional system libraries used ..... snappy ffmpeg opus libwebp opus ffmpeg minizip zlib jsoncpp protobuf
      Optional bundled libraries used .... icu libevent libvpx snappy
      
      > ls /opt/local/include/snappy* /opt/local/lib/cmake/Snappy
      /opt/local/include/snappy-c.h /opt/local/include/snappy-sinksource.h
      /opt/local/include/snappy.h /opt/local/include/snappy-stubs-public.h
      
      /opt/local/lib/cmake/Snappy:
      SnappyConfig.cmake SnappyConfigVersion.cmake SnappyTargets.cmake SnappyTargets-macports.cmake
      

       

      This worked before because one of the other dependencies inserted `-I/opt/local/include` via pkg-config which broke the build elsewhere. Now it fails because at some point snappy.h isn't being found.

       

      I'd say that the configure step should either raise an error ("you asked for system-snappy but I can't find that, sort it out") or be fixed so that it finds the dependency reliably.

       

      In a slight variation, the configure process discovers that there's a usable system zlib:

       

      Project MESSAGE: Running: /path/to/build/src/3rdparty/chromium/tools/gn/out/Release/gn gen /path/to/build/src/core/Release --script-executable=/opt/local/bin/python2 --args='use_qt=true is_component_build=false is_shared=true enable_media_router=false enable_nacl=false enable_remoting=false enable_web_speech=false use_experimental_allocator_shim=false use_allocator="none" v8_use_external_startup_data=false treat_warnings_as_errors=false enable_basic_printing=true enable_print_preview=true enable_pdf=true enable_plugins=true enable_widevine=true enable_spellcheck=true enable_webrtc=true proprietary_codecs=true ffmpeg_branding="Chrome" symbol_level=0 remove_webcore_debug_symbols=true remove_v8base_debug_symbols=true optimize_for_size=true use_cups=false use_gconf=false use_gio=false use_gnome_keyring=false use_kerberos=false linux_use_bundled_binutils=false use_nss_certs=true use_openssl_certs=false no_delete_null_pointer_checks=true is_clang=false custom_toolchain="/path/to/build/src/toolchain:target" host_toolchain="/path/to/build/src/toolchain:host" host_cpu="x64" pkg_config="pkg-config" use_system_zlib=true use_system_minizip=true use_system_libpng=true use_system_libjpeg=true use_pulseaudio=true use_alsa=true use_system_libffi=true use_system_libwebp=true use_system_opus=true use_system_ffmpeg=true use_sysroot=false enable_session_service=false enable_notifications=false toolkit_views=false use_gold=false is_debug=false qtwebengine_target="/path/to/build/src/core/Release:QtWebEngineCore"' --root=/path/to/qt-everywhere-opensource-src-5.9.3/qtwebengine/src/3rdparty/chromium

       

      but then continues to build the embedded zlib copy which has not been modified (or configured) to find its headers in a non-system location. This remained undetected when I had -I/opt/local/include in my options.

       

      [6454/18419] CXX obj/third_party/zlib/zip/zip.o
      FAILED: obj/third_party/zlib/zip/zip.o 
      /usr/bin/c++ -MMD -MF obj/third_party/zlib/zip/zip.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DTOOLKIT_QT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -Igen -I../../../../qt-everywhere-opensource-src-5.9.3/qtwebengine/src/3rdparty/chromium -Igen -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/pcre -I../../../../qt-everywhere-opensource-src-5.9.3/qtwebengine/src/3rdparty/chromium/third_party/icu/source/common -I../../../../qt-everywhere-opensource-src-5.9.3/qtwebengine/src/3rdparty/chromium/third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -pthread -m64 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Os -fno-ident -fdata-sections -ffunction-sections -g0 -fvisibility=hidden -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-delete-null-pointer-checks -Wno-narrowing -fno-rtti -fno-exceptions -c ../../../../qt-everywhere-opensource-src-5.9.3/qtwebengine/src/3rdparty/chromium/third_party/zlib/google/zip.cc -o obj/third_party/zlib/zip/zip.o
      In file included from ../../../../qt-everywhere-opensource-src-5.9.3/qtwebengine/src/3rdparty/chromium/third_party/zlib/google/zip_internal.h:20:0,
                       from ../../../../qt-everywhere-opensource-src-5.9.3/qtwebengine/src/3rdparty/chromium/third_party/zlib/google/zip.cc:17:
      gen/third_party/zlib/contrib/minizip/unzip.h:5:10: fatal error: minizip/unzip.h: No such file or directory
       #include <minizip/unzip.h>
                ^~~~~~~~~~~~~~~~~
      compilation terminated.
      
      

       

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qt_webengine_team Qt WebEngine Team
            rjvbertin René Bertin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes