Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-65638

Verify if we can eradicate QKeyMapper class (it is a class in *_p.h file)

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Reported
    • Priority: P3: Somewhat important
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Technical Risk:
      Normal

      Description

      It looks that when moving from Qt4 to Qt5 the complexity of this class has been reduced to the minimum. In process of this some functionality have been lost, e.g QTBUG-27681. and most logic now is handled via QLocale. So QKeyMapper doesn't really do anything useful, just adds an extra layer of indirection (what could be done directly from qshortcutmap.cpp and qplatforminputcontext_p.h). See the attached sample WIP patch and https://codereview.qt-project.org/#/c/216060/

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            paeglis Gatis Paeglis
            Reporter:
            paeglis Gatis Paeglis
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Gerrit Reviews

                There are no open Gerrit changes