Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-65720

A copy-paste typo in qiconloader.cpp

    XMLWordPrintable

Details

    • Bug
    • Resolution: Invalid
    • Not Evaluated
    • None
    • 5.10.0
    • GUI: Look'n'Feel
    • None

    Description

      The mistake is in /src/gui/image/qiconloader.cpp → QIconLoader::findIconHelper() → line 414, which is the last line in the following excerpt:

                  auto cache = theme.m_gtkCaches.at(i);
                  if (cache->isValid()) {
                      const auto result = cache->lookup(iconNameFallback);
                      if (cache->isValid()) {
      

      That prevents finding of newly installed icons and can cause other problems too. It should be:

                  auto cache = theme.m_gtkCaches.at(i);
                  if (cache->isValid()) {
                      const auto result = cache->lookup(iconNameFallback);
                      if (!result.isEmpty()) {
      

      Sorry, I don't use gerrit; please correct it!

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            ogoffart Olivier Goffart (Woboq GmbH)
            tsujan Tsu Jan
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes