Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-65785

Syntax errors in Qt source qmake projects

    XMLWordPrintable

Details

    • Bug
    • Resolution: Out of scope
    • Not Evaluated
    • None
    • 5.10.0
    • Build tools: qmake
    • None
    • <not required>

    Description

      Hi! I'm developing qmake replacement called qmake-ng (https://github.com/eraxillan/qmake-ng). Currently it is at early alpha stage. Only parser implemented, but tool already can serve one as a strict linter.

      So, i've run it on Qt source qmake projects and find several syntax issues:

      1) https://github.com/qt/qtbase/blob/5.10/mkspecs/features/winrt/package_manifest.prf#L100

      Extra closing parenthesis on the line end

      2) https://github.com/qt/qtbase/blob/5.10/mkspecs/features/spec_post.prf#L38

      Extra semicolon on the line end

      3) https://github.com/qt/qtbase/blob/5.10/mkspecs/features/qt_configure.prf#L1010

      Extra semicolon on the line end

      4) https://github.com/qt/qtwebengine/blob/5.10/mkspecs/features/platform.prf#L147

      Extra colon (need only one instead of two)

      5) https://github.com/qt/qtwebengine/blob/5.10/mkspecs/features/configure.prf#L52

      Extra semicolon on the line end

      6) https://github.com/qt/qtremoteobjects/blob/5.10/tests/auto/integration_multiprocess/server/server.pro#L16

      Backslash on the line end is absent

      7) https://github.com/qt/qtbase/blob/5.10/tests/auto/tools/qmake/testdata/export_across_file_boundaries/foo.pro#L12

      https://github.com/qt/qtbase/blob/5.10/tests/auto/tools/qmake/testdata/export_across_file_boundaries/foo.pro#L16

      Probably "\$\$" instead of "\$$"?

      8) https://github.com/qt/qtbase/blob/5.10/tests/auto/network/ssl/ssl.pro#L16

      Extra backslash on the line end

      9) https://github.com/qt/qtbase/blob/5.10/src/plugins/platforms/windows/windows.pri#L56

      Backslash on the line end is absent

      10) https://github.com/qt/qtbase/blob/5.10/src/plugins/sqldrivers/configure.pri#L54

      Extra square bracket on the line end

      11) https://github.com/qt/qtbase/blob/5.10/src/widgets/util/util.pri#L31

      Extra backslash on the line end

      12) https://github.com/qt/qtmultimedia/blob/5.10/examples/multimedia/multimedia.pro#L14

      Extra backslash on the line end

      13) https://github.com/qt/qtdeclarative/blob/5.10/tests/auto/quick/pointerhandlers/pointerhandlers.pro#L9

      Extra backslash on the line end

      14) https://github.com/qt/qtconnectivity/blob/5.10/src/bluetooth/osx/osxbt.pri#L3

      C-style comment ("//") instead of qmake one ("#")

       

      With best regards, Alexander

       

      P.S. Why those issues just ignored by original qmake, i.e. build passed?

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            buddenha Oswald Buddenhagen
            eraxillan Alexander Kamyshnikov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes