Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-67088

[REG 5.10.1 -> 5.11.0 Beta] Compilation of .UI files does not write all necessary includes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Not Evaluated
    • Resolution: Duplicate
    • Affects Version/s: 5.11.0 Beta 1
    • Fix Version/s: 5.11.0
    • Component/s: Build tools: uic
    • Labels:
      None
    • Environment:
      Visual Studio 2017 x64
    • Commits:
      4b24a61ecc4a1dbd5f8d32c2078ccdaf53c134d1

      Description

      Since updating to 5.11.0 beta from 5.10.1, the compilation of the .ui file is missing the include for QIcon.

      The ui file includes the following code:

        <property name="windowIcon">
         <iconset resource="/../Icons/Icons.qrc">
          <normaloff>:/Icons/info.png</normaloff>:/Icons/info.png</iconset>
        </property>

      However, on compilation of this file, it is no longer adding #include <QIcon> to top of the generated .h file and as such compilation fails.

      I also got a similar result with another .ui file where it was missing an include to <QAction>.

       

       

       

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            jkobus Jarek Kobus
            Reporter:
            lmv Luke
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes