Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-68207

Remove hacks from squish install common script

    XMLWordPrintable

Details

    • Bug
    • Resolution: Invalid
    • P2: Important
    • None
    • 5.11.0
    • Coin Configuration
    • None

    Description

       https://codereview.qt-project.org/gitweb?p=qt/qt5.git;a=blob;f=coin/provisioning/common/unix/squishInstall.sh;h=0ed9b0a072c6742792406ce285487cf1905506af;hb=refs/heads/5.11.0

      The squish install common script tries to guess the target platform by

      74     # Check which platform
      75     if uname -a |grep -q Darwin; then
      76         usersGroup="staff"
      77         mountFolder="/Volumes"
      78         squishLicenseDir="/Users/qt"
      79     elif uname -a |grep -q "el6\|el7"; then
      80         usersGroup="qt"
      81         mountFolder="/tmp"
      82         squishLicenseDir="/root"
      83     elif uname -a |grep -q "Ubuntu"; then
      84         usersGroup="users"
      85         mountFolder="/tmp"
      86         squishLicenseDir="/home/qt"
      87     else
      88         usersGroup="users"
      89         mountFolder="/tmp"
      90         squishLicenseDir="/root"
      91     fi
      

      This should be cleaned up by simply giving the target as input argument in the invoking platform specific script.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            tosaraja Tony Sarajärvi
            aakeskimo Aapo Keskimölö
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes