Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-68238

[REG 5.10] QSpinBox no longer gets a frame (SH_SpinBox_ButtonsInsideFrame check is wrong)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Done
    • Affects Version/s: 5.11.0 RC 1
    • Fix Version/s: 5.11.1
    • Component/s: Widgets: Styles
    • Labels:
      None
    • Commits:
      9ffb00130624b90dabab9cf5dd6cb53999b32bdd

      Description

      Spin boxes no longer get a frame with common styles (Windows, Breeze, Skulpture), because the check if QStyle::SC_SpinBoxFrame needs to be included in option->subControls is wrong. The commit in qcommonstyle.cpp made 'true' the default value for SH_SpinBox_ButtonsInsideFrame, while the check in qabstractspinbox.cpp checks for a 'false' value to include the QStyle::SC_SpinBoxFrame.

      http://code.qt.io/cgit/qt/qtbase.git/commit/src/widgets/styles?id=80515c811a4c455d7f2fb9ded751b2406b08d045

      http://code.qt.io/cgit/qt/qtbase.git/commit/src/widgets/widgets/qabstractspinbox.cpp?id=80515c811a4c455d7f2fb9ded751b2406b08d045

        Attachments

        1. qtbug68238.jpg
          qtbug68238.jpg
          38 kB
        2. qtbug68238.zip
          2 kB
        For Gerrit Dashboard: QTBUG-68238
        # Subject Branch Project Status CR V
        229296,2 QAbstractSpinBox: Fix missing frame condition 5.11 qt/qtbase Status: MERGED +2 0

          Activity

            People

            Assignee:
            qt.team.quick.subscriptions Qt Quick and Widgets Team
            Reporter:
            cfeck Christoph Feck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes