Details
-
Task
-
Resolution: Done
-
P3: Somewhat important
-
5.9.5
-
None
-
Debian 8 on G5
gcc 4.9.2
-
b206d1c8082a9e01ad3755d311a4cf683ec35161 295b2dde7f0b9e28e7d450dc8b028c7b1900e419 f2862b4d5def2c07b8b018532ab74a12b129db2c
Description
but maybe it's just an old-gcc issue, or some recent change in enabled warnings...
In file included from /usr/include/arpa/inet.h:22:0,
from /home/rutledge/dev/qt59/qtbase/src/plugins/platforms/vnc/qvnc.cpp:53:
/home/rutledge/dev/qt59/qtbase/src/plugins/platforms/vnc/qvnc.cpp: In member function 'void QVncClientCursor::write(QVncClient*) const':
/home/rutledge/dev/qt59/qtbase/src/plugins/platforms/vnc/qvnc.cpp:554:50: error: narrowing conversion of '((const QVncClientCursor*)this)->QVncClientCursor::hotspot.QPoint::x()' from 'int' to 'const quint16 {aka const short unsigned int}' inside { } [-Werror=narrowing]
htons(hotspot.x()), htons(hotspot.y()),
^
/home/rutledge/dev/qt59/qtbase/src/plugins/platforms/vnc/qvnc.cpp:554:70: error: narrowing conversion of '((const QVncClientCursor*)this)->QVncClientCursor::hotspot.QPoint::y()' from 'int' to 'const quint16 {aka const short unsigned int}' inside { } [-Werror=narrowing]
htons(hotspot.x()), htons(hotspot.y()),
^
/home/rutledge/dev/qt59/qtbase/src/plugins/platforms/vnc/qvnc.cpp:555:53: error: narrowing conversion of '((const QVncClientCursor*)this)->QVncClientCursor::cursor.QImage::width()' from 'int' to 'const quint16 {aka const short unsigned int}' inside { } [-Werror=narrowing]
htons(cursor.width()),
^
/home/rutledge/dev/qt59/qtbase/src/plugins/platforms/vnc/qvnc.cpp:556:54: error: narrowing conversion of '((const QVncClientCursor*)this)->QVncClientCursor::cursor.QImage::height()' from 'int' to 'const quint16 {aka const short unsigned int}' inside { } [-Werror=narrowing]
htons(cursor.height()) };
^
Attachments
| For Gerrit Dashboard: QTBUG-68390 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 230013,4 | VNC plugin: explicitly cast int to uint16_t before calling htons | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 230317,2 | VNC plugin: explicitly cast int to uint16_t before calling htons | 5.9 | qt/qtbase | Status: MERGED | +2 | 0 |
| 236730,2 | VNC plugin: explicitly cast int to uint16_t before calling htons | 5.11 | qt/qtbase | Status: MERGED | +2 | 0 |