Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-68884

Missing isNull check in QOpenGLTexture (crash in driver)

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • 6.2.8, 6.5.1, 6.6.0
    • 5.11.0
    • GUI: OpenGL
    • None
    • a561d52a8 (dev), 6d25cd1db (6.5), 44926b9a0 (tqtc/lts-6.2)

    Description

      We have experienced crashes in NVidia drivers when creating textures from very large (25k x 25k) QImage instances.

      After some poking around, I believe this might be caused by a missing check in QOpenGLTexture::setData. Line 3473 in qopengltexture.cpp converts the input QImage to RGBA8888. However, it does not check if the resulting QImage is 'null'.

      A null check is present earlier in the function, but the format conversion can fail when converting to a format larger data size (due to the overflow checks).

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            lagocs Laszlo Agocs
            dethtoll Alex Goldberg
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes