Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-69365

Some README.chromium files contain inexisting license files

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P1: Critical P1: Critical
    • 5.12.0
    • 5.9.6, 5.11.0, 5.11.1
    • WebEngine
    • None

      The README.chromium files contain the attribution for third-party sources in the Chromium project (that is included in the Qt WebEngine module). However, some of these files cannot be found in the qt/qtwebengine repository, thus preventing them from being correctly displayed in the Licenses used in Qt documentation page.

      Files

      These README.chromium files mention licenses files that are located in blacklisted directories (src directories that are not included into Qt because the qtwebengine/tools/scripts/take_snapshot.py script ignores them):

      • third_party/jsr-305/README.chromium
      • third_party/wayland/README.chromium

      These README.chromium files mention licenses files in a folder that isn't existing at all:

      • buildtools/third_party/libc++/trunk/LICENSE.TXT
      • buildtools/third_party/libc++abi/trunk/LICENSE.TXT
      • buildtools/third_party/libunwind/trunk/LICENSE.TXT
      • third_party/libaom/source/libaom/LICENSE

      These folders contain only a README.chromium file (and no code), so we probably don't need them anymore so they could be removed:

      • third_party/glslang-angle/
      • third_party/spirv-headers/
      • third_party/spirv-tools-angle/
      • third_party/vulkan-validation-layers/

      Note: all the mentioned paths are located in the qtwebengine/src/3rdparty/chromium/ folder.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            kkohne Kai Köhne
            nicolasettlin Nicolas Ettlin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes