Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-70449

Consolidate the error messages handling in the CAN plugins

    XMLWordPrintable

    Details

    • Type: Suggestion
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.12
    • Fix Version/s: 5.14
    • Component/s: SerialBus: CAN Bus
    • Labels:
      None
    • Commits:
      fd9b9c73ca60c66d01376ddbd6d36e9ea2dfa95c

      Description

      Right now we have two means to report errors during operation:

      1. print log messages with qCDebug/qCWarning
      2. call QCanBusDevice::setError(), which emits a signal

      For now, different places handle errors in different ways, some only log the error, some only emit the signal.

      The best solutions would IMHO be to do both, as it allows the end user to choose how to react to errors:

      • connect to errorOccurred() and handle the problem in user code
      • enable the logging to see errors in a log
      • ignore errors by disabling logging and not connecting to the errorOccurred() signal

        Attachments

        For Gerrit Dashboard: QTBUG-70449
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            aha_1980 André Hartmann
            Reporter:
            aha_1980 André Hartmann
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes