Details
-
Sub-task
-
Resolution: Done
-
P2: Important
-
None
-
None
Description
Copied from QTBUG-70346:
qtquickontrols2/tests/manual/testbench
- Fusion style button text is dark with low contrast
https://codereview.qt-project.org/#/c/251609/
- Controls do not pick up “live” light/dark theme changes, app restart is needed.
I'm not sure if this one is possible currently, and I wouldn't consider it a high priority.
For my own reference, I think the change happens here: http://code.qt.io/cgit/qt/qtbase.git/tree/src/plugins/platforms/cocoa/qcocoatheme.mm?id=8915904e2a56d46bdedf64f9a7a5e331ae9d00e1#n159
QGuiApplicationPrivate::notifyThemeChanged() also emits qGuiApp->paletteChanged(*app_pal), which might be relevant.
- None of the styles pick up the system accent color.
https://codereview.qt-project.org/#/c/221775/ is an example of adding a new palette role, though care must be taken not to introduce the same bug as QTBUG-72555.
- Otherwise OK: fusion style dark mode and the dark versions of Material/Universal work well
Attachments
Issue Links
- resulted in
-
QTBUG-73435 React to runtime system theme changes without requiring app restart
- Reported
-
QTBUG-73453 Respect macOS accent colour
- Reported
For Gerrit Dashboard: QTBUG-70819 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
251609,3 | Fusion: use white ButtonText when a dark system theme is in use | 5.12 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
252271,2 | Fusion: fix buttons colors | 5.12 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |