Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-71010

Broken YarrPattern on Linux

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.12.0 Alpha, 5.12.0 Beta 1
    • Fix Version/s: None
    • Labels:
      None
    • Platform/s:
      Linux/X11
    • Commits:
      f97e72d1da5961b5702f05653e42c9e853f75400

      Description

      If we try to compile Qt 5.12-beta1 it stops with this error.

      make[3]: Entering directory '/[...]/qtdeclarative/src/qml'
      g++ -c -include .pch/Qt5Qml -pipe -Wno-expansion-to-defined -Wno-c++0x-compat -g -Og -std=c++11 -fvisibility=hidden -fvisibility-inlines-hidden -fno-exceptions -Wall -W -Wno-expansion-to-defined -Wvla -Wdate-time -Wshift-overflow=2 -Wduplicated-cond -Wno-stringop-overflow -D_REENTRANT -fPIC -DQT_NO_URL_CAST_FROM_STRING -DQT_NO_INTEGER_EVENT_COORDINATES -DQT_NO_FOREACH -DWTF_EXPORT_PRIVATE= -DJS_EXPORT_PRIVATE= -DENABLE_ASSEMBLER_WX_EXCLUSIVE=1 -DWTFReportAssertionFailure=qmlWTFReportAssertionFailure -DWTFReportAssertionFailureWithMessage=qmlWTFReportAssertionFailureWithMessage -DWTFReportBacktrace=qmlWTFReportBacktrace -DWTFInvokeCrashHook=qmlWTFInvokeCrashHook -DENABLE_LLINT=0 -DENABLE_DFG_JIT=0 -DENABLE_DFG_JIT_UTILITY_METHODS=1 -DENABLE_JIT_CONSTANT_BLINDING=0 -DBUILDING_QT__ -DWTF_USE_UDIS86=0 -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_BUILD_QML_LIB -DQT_BUILDING_QT -DQT_NO_CAST_TO_ASCII -DQT_ASCII_CAST_WARNINGS -DQT_MOC_COMPAT -DQT_USE_QSTRINGBUILDER -DQT_DEPRECATED_WARNINGS -DQT_DISABLE_DEPRECATED_BEFORE=0x050000 -DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -Imemory -I. -Icompiler -I. -Ijsruntime -I. -Ijit -I. -Idebugger -Ianimations -I../3rdparty/masm/jit -I../3rdparty/masm/assembler -I../3rdparty/masm/runtime -I../3rdparty/masm/wtf -I../3rdparty/masm/stubs -I../3rdparty/masm/stubs/runtime -I../3rdparty/masm/stubs/wtf -I../3rdparty/masm -I../3rdparty/masm/disassembler -I../3rdparty/masm/disassembler/udis86 -I.generated -I../../include -I../../include/QtQml -I../../include/QtQml/5.12.0 -I../../include/QtQml/5.12.0/QtQml -I. -I/[...]/qtbase/include/QtCore/5.12.0 -I/[...]/qtbase/include/QtCore/5.12.0/QtCore -I/[...]/qtbase/include -I/[...]/qtbase/include/QtNetwork -I/[...]/qtbase/include/QtCore -I.moc -I/[...]/dist/include -I/[...]/qtbase/mkspecs/linux-g++ -o .obj/qv4compileddata.o compiler/qv4compileddata.cpp
      In file included from ../3rdparty/masm/yarr/YarrInterpreter.h:29,
                       from ../../include/QtQml/5.12.0/QtQml/private/../../../../../src/qml/jsruntime/qv4regexp_p.h:63,
                       from ../../include/QtQml/5.12.0/QtQml/private/../../../../../src/qml/jsruntime/qv4regexpobject_p.h:61,
                       from ../../include/QtQml/5.12.0/QtQml/private/qv4regexpobject_p.h:1,
                       from compiler/qv4compileddata.cpp:47:
      ../3rdparty/masm/yarr/YarrPattern.h: In member function 'JSC::Yarr::PatternAlternative* JSC::Yarr::PatternDisjunction::addNewAlternative()':
      ../3rdparty/masm/yarr/YarrPattern.h:316:36: error: 'make_unique' is not a member of 'std'
               m_alternatives.append(std::make_unique<PatternAlternative>(this));
                                          ^~~~~~~~~~~
      ../3rdparty/masm/yarr/YarrPattern.h:316:36: note: 'std::make_unique' is defined in header '<memory>'; did you forget to '#include <memory>'?
      ../3rdparty/masm/yarr/YarrPattern.h:36:1:
      +#include <memory>
       #include <wtf/text/WTFString.h>
      ../3rdparty/masm/yarr/YarrPattern.h:316:36:
               m_alternatives.append(std::make_unique<PatternAlternative>(this));
                                          ^~~~~~~~~~~
      ../3rdparty/masm/yarr/YarrPattern.h:316:66: error: expected primary-expression before '>' token
               m_alternatives.append(std::make_unique<PatternAlternative>(this));
                                                                        ^
      make[3]: *** [Makefile:18902: .obj/qv4compileddata.o] Error 1
      

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              • Assignee:
                laknoll Lars Knoll
                Reporter:
                misery André Klitzing
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes