Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-72226

[REG 5.11 -> 5.12] QToolButton with icon and text prematurely elides text

XMLWordPrintable

    • All
    • 25231c40489e54d57998fa44385ad832cc32b30d (qt/qtbase/5.12) 7024090e1dc7043e7a2a692ede105bcb7952781d (qt/qtbase/5.12)

      https://codereview.qt-project.org/227511/ allows text in a QToolButton to elide. However, in some cases it causes a "premature" eliding. That means that even with preferred width, the QToolButton elides its text.

      The attached QTBUG-72226.zip contains a minimal application to reproduce the issue.

      before fix:

      after fix:

      Key ingredients are:

      • QToolButton in a QHorizontalLayout
      • button has an icon
      • button has text
      • text contains a & (mnemonic)
      • toolButtonStyle is Qt::ToolButtonTextBesideIcon

      The issue was originally fount in Qt Creator's amend/commit editor (QTCREATORBUG-21551). This is how it looks like:

      before fix:

      after fix

        1. Qt512ElidesTextInButtonsWithIconAndText_fixed.png
          Qt512ElidesTextInButtonsWithIconAndText_fixed.png
          3 kB
        2. Qt512ElidesTextInButtonsWithIconAndText_fixed2.png
          Qt512ElidesTextInButtonsWithIconAndText_fixed2.png
          2 kB
        3. Qt512ElidesTextInButtonsWithIconAndText.png
          Qt512ElidesTextInButtonsWithIconAndText.png
          2 kB
        4. QTBUG-72226.zip
          0.8 kB
        5. QTBUG-72226-testapp.png
          QTBUG-72226-testapp.png
          3 kB
        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            chehrlic Christian Ehrlicher
            portale Alessandro Portale
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes