Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-72288

qt-everywhere-src-5.11.3/qtwayland/src/compositor/compositor_api/qwaylandoutputmode.cpp:101]: (style) Same expression on both sides of '!='.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Not Evaluated
    • Resolution: Done
    • Affects Version/s: 5.11.3
    • Fix Version/s: 5.12.1, 5.15.1, 6.1.0 RC
    • Component/s: QPA: Wayland
    • Labels:
      None
    • Platform/s:
      All
    • Commits:
      d25b3b7f1059d5561bce3efe7ea903ea76d4e888 (qt/qtwayland/5.12)

      Description

      Source code is

       

      bool QWaylandOutputMode::operator!=(const QWaylandOutputMode &other) const
      {
       return size() != other.size() || refreshRate() != refreshRate();
      }
      

      Maybe better code

       

      bool QWaylandOutputMode::operator!=(const QWaylandOutputMode &other) const
      {
       return size() != other.size() || refreshRate() != other.refreshRate();
      }
      

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            johanhelsing Johan Helsing
            Reporter:
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes