Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-72290

qt-everywhere-src-5.11.3/qtbase/src/corelib/thread/qreadwritelock.cpp: 2 * suspicious test ?

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Not Evaluated
    • Resolution: Done
    • Affects Version/s: 5.11.3
    • Fix Version/s: 5.12.0
    • Component/s: Core: Other
    • Labels:
      None
    • Platform/s:
      All
    • Commits:
      4e680bee8680834353bd0f38dc6b6c9e9a86d8d8

      Description

      1.

      qt-everywhere-src-5.11.3/qtbase/src/corelib/thread/qreadwritelock.cpp:626]: (style) Same expression on both sides of '&&'.

       

      Source code is

       

      Q_ASSERT(!d->waitingReaders && !d->waitingReaders && !d->readerCount && !d->writerCount);

      Maybe better code

       

      Q_ASSERT(!d->waitingReaders && !d->waitingWriters && !d->readerCount && !d->writerCount);

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            thiago Thiago Macieira
            Reporter:
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes