Details
-
Technical task
-
Resolution: Done
-
Not Evaluated
-
None
-
None
-
None
Description
Guiding pseudocode from meeting:
1) in foo::func, turn the global access into a parameter void foo::func(const QMap<...>& features) { // no more using the global for (auto x : features) /* stuff */ } 2) if necessary, turn the parameter into a member class foo { QMap<QByteArray, Feature> *features public: void some_setter(const QMap<QByteArray, Feature> &features); }; void foo::func() { for (auto x : features) /* now fine */ }
Attachments
Issue Links
- is required for
-
QTBUG-73314 Finish getting rid of globals
-
- Closed
-
For Gerrit Dashboard: QTBUG-73311 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
251515,6 | Make ConfigureData non-global | master | qt-apps/tqtc-qt-config-gui | Status: MERGED | +2 | 0 |
253267,3 | Make features non-global | master | qt-apps/tqtc-qt-config-gui | Status: MERGED | +2 | 0 |