Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-73726

macOS: Unbalanced NSEnable/DisableScreenUpdates

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.12
    • Fix Version/s: 5.12.2, 5.14.0 Alpha
    • Component/s: QPA
    • Labels:
      None
    • Platform/s:
      macOS
    • Commits:
      77389ad8ff9fd3dc56f5a398fab11a993e7a621c (qt/qtbase/5.12)

      Description

      As noted in https://codereview.qt-project.org/#/c/238958/, windowDidResize: does not neccecarily have a matching windowWillResize: (e.g. during zoom it doesn't). The result is that we enable screen updates without a matching disable first, resulting in log messages "SLSReenableUpdate: unbalanced enable/disable update".

      The screen update disable was added as a workaround for http://openradar.appspot.com/radar?id=4990815088672768, but since we've disabled threaded GL rendering support on macOS, the workaround isn't needed right now. We should:

      • Disable it if threaded rendering is disabled.
      • make sure to always pair up the enable/disable.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              vestbo Tor Arne Vestbø
              Reporter:
              vestbo Tor Arne Vestbø
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes