Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-74286

Reimplement QLocaleData::stringTo(Uns|)LongLong() to take size of string

    XMLWordPrintable

Details

    • All
    • 13
    • Foundation_Sprint 41 (Team 1)

    Description

      In the process, remove the dead-code QLocaleData::stringToDouble and, deploying this so as to make QByteArray::nulTerminated(), remove that monstrosity, too.

      As stringToLongLong() and stringToUnsLongLong() currently don't take their size, callers are obliged to '\0'-terminate their data before calling; this may oblige callers to copy the data if the subject string is not the tail of the actual string of which it is a part.

      Furthermore, as these two functions (lacking knowledge of the data's size) necessarily stop at the first '\0' in the data, they may fail to recognise a '\0' internal to the data, along with any characters after it within the intended size, as "trailing junk". thiago says this introduces security concerns.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-85580 Often-used function `qt_asciiToDouble` may read past end of buffer

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-85581 QByteArray .toDouble() does not call nulTerminated()

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-79902 QLocale: make fuller and more faithful use of the CLDR data

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Open

          Suggestion - Public suggestions QTBUG-66115 Let (QString|QLocale)::toFloat ignore trailing non-digits

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              Eddy Edward Welbourne
              Eddy Edward Welbourne
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 1 week
                  1w
                  Remaining:
                  Remaining Estimate - 1 week
                  1w
                  Logged:
                  Time Spent - Not Specified
                  Not Specified

                  Gerrit Reviews

                    There are no open Gerrit changes