Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-75377

Don't mark decorations as dirty when the buffer size doesn't change

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Done
    • Icon: P3: Somewhat important P3: Somewhat important
    • 5.14.0 Alpha
    • 5.13.0 Beta2
    • QPA: Wayland
    • None
    • Linux/Wayland
    • 1cff2a85fd6dcf4bef8826ee13216aa6a563c236 (qt/qtwayland/dev) 

      #ifdef Q_OS_SYLIXOS
 // Here you should only redraw the border if the window size has changed.
 if (windowDecoration() && window()->isVisible() && oldSize != buffer->image()->sizeInBytes())
 #else
 if (windowDecoration() && window()->isVisible())
 #endif
 windowDecoration()->update();

      Note:
      At each redraw, there is no need to redraw the border if there is no window size change, otherwise each draw will trigger the drawing of the border, increasing the unnecessary performance loss.

      This code in: qt5/qtwayland/src/client/qwaylandshmbackingstore.cpp

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            johanhelsing Johan Helsing
            xiaoyan xiao yan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes