Details
-
User Story
-
Resolution: Done
-
P1: Critical
-
None
-
None
Description
The QtWidgets module includes several components that are not widget specific, and that should be moved out into a separate module, into QtGUI, or into QtCore.
Recommendations:
- Run a Qt Creator's clang checks on the code base first to identify (fix in Qt 5)
- Static invocations: Fix qApp->sendEvent() and similar to QCoreApplication::sendEvent() (reduce dependencies on QApplication)
- Use member initialization in private classes to reduce constructor #ifdefery
- Check the autotest of the class and port to Qt 5 signal slot connections and ideally also fix nullptr to get rid of things like (Class *)0.
- On no account introduce workarounds forward-declaring QtWidget classes from QtGui . This creates huge problems for Qt for Python.
- Test source compatibility by compiling Qt Designer
In conjunction with the QAction removal: it might make sense to move QShortcut out (that is, extract a QAbstractShortcut into QtGui) - depending on whether that makes sense for Quick controls (Friedemann, 6/19).
Attachments
Issue Links
- depends on
-
QTBUG-68080 we need to move popup event forwarding logic from QWidgetWindow::handleMouseEvent() to QGuiApplication
- Closed
-
QTBUG-41884 Split QSvgWidget out ot QtSvg to remove dependency on Widgets
- Closed
-
QTBUG-40040 Move Undo Framework out of widgets
- Closed
-
QTBUG-69478 Move QAction to QtGui
- Closed
-
QTBUG-79638 Move QShortcut out of QtWidgets
- Closed
- is duplicated by
-
QTBUG-66178 API to move out of Qt Widgets into Qt GUI in Qt 6
- Withdrawn
- relates to
-
QTBUG-76497 Move GraphicsView into separate module
- Closed
1.
|
Move undo/redo framework out | Closed | Volker Hilsheimer | |
2.
|
Move QAction out | Closed | Lars Knoll | |
3.
|
Move QFileSystemWatcher out | Closed | Lars Knoll |
Gerrit Reviews
For Gerrit Dashboard: QTBUG-76493 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
265700,29 | QtWidgets: Fix static method invocations | dev | qt/qtbase | Status: MERGED | +2 | 0 |
266787,5 | QShortcut: Brush up the code, preparing the extraction of a base class to QtGui | dev | qt/qtbase | Status: MERGED | +2 | 0 |
266788,2 | tst_QShortcut: Brush up the code, preparing the extraction of a base class to QtGui | dev | qt/qtbase | Status: MERGED | +2 | 0 |
266905,4 | tst_QShortcut: Remove test widget and other member variables | dev | qt/qtbase | Status: MERGED | +2 | 0 |
267022,9 | Extract QGuiShortcut | dev | qt/qtbase | Status: MERGED | +2 | 0 |
267487,3 | QFileSystemModel: Improve class structure | dev | qt/qtbase | Status: MERGED | +2 | 0 |
267488,10 | QFileInfoGatherer: Make it possible to turn off file watching | dev | qt/qtbase | Status: MERGED | +2 | 0 |
267489,9 | QFileSystemModel: Add options | dev | qt/qtbase | Status: MERGED | +2 | 0 |
267490,4 | QFileSystemModel: Brush up the test | dev | qt/qtbase | Status: MERGED | +2 | 0 |
267491,4 | QFileSystemModel: Remove model member variable from test | dev | qt/qtbase | Status: MERGED | +2 | 0 |
270658,11 | Brush up tst_QStyleSheetStyle | 5.15 | qt/qtbase | Status: MERGED | +2 | 0 |
270659,8 | tst_QStyleSheetStyle: Pass on High DPI screens | 5.15 | qt/qtbase | Status: MERGED | +2 | 0 |
271351,2 | tst_QStyle: Remove unused baseline images (Windows Vista/macOS) | dev | qt/qtbase | Status: MERGED | +2 | 0 |
271352,6 | Brush up tst_QStyle | 5.15 | qt/qtbase | Status: MERGED | +2 | 0 |
273002,1 | Brush up tst_QStyleSheetStyle | 5.14 | qt/qtbase | Status: ABANDONED | 0 | 0 |
273003,1 | tst_QStyleSheetStyle: Pass on High DPI screens | 5.14 | qt/qtbase | Status: ABANDONED | 0 | 0 |
273004,1 | Brush up tst_QStyle | 5.14 | qt/qtbase | Status: ABANDONED | 0 | 0 |
273755,10 | Brush up the Windows styles | 5.14 | qt/qtbase | Status: MERGED | +2 | 0 |
278170,3 | Handle -no-feature-shortcut | 5.15 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
278171,2 | Handle -no-feature-shortcut | 5.15 | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
278199,7 | QShortcut: Properly port to the new configure system | dev | qt/qtbase | Status: MERGED | +2 | 0 |