Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-77006

[REG: 5.12.3->5.12.4]: Changing a stylesheet at runtime does not effect children that are not direct children of the widget being changed

    XMLWordPrintable

Details

    • All
    • 9b6179cf957c32e0c02547d510dfee2088f02340 (qt/qtbase/5.13) 4a9292f16915345b5a02a43eaa244d865d9ea49c (qt/qtbase/5.12)

    Description

      When changing the StyleSheet during runtime, the MainWindow does not apply the new stylesheet to its children. This was working since Qt 4.8.1 until Qt 5.12.3.

      I have two stylesheets (attached). When loading one of the stylesheet at startup, the appearance is ok, but changing the stylesheet does not work (see screenshots).

      I made it work again with a workaroun, but this is very slow:

      void MainWindow::changeStyleSheet( const QByteArray& styleSheet )

      { setStyleSheet( myStyleSheet ); updateStyleSheet( this ); }

      void MainWindow::updateStyleSheet( QWidget* widget )
      {
      if( widget )
      {
      widget->style()->unpolish( widget );
      widget->style()->polish( widget );
      widget->update();

      foreach( QObject* o, widget->children() )

      { updateStyleSheet( qobject_cast< QWidget* >( o ) ); }

      }
      }
      }

      Attachments

        1. change_from_dark_to_light.png
          change_from_dark_to_light.png
          38 kB
        2. dark_ok.png
          dark_ok.png
          27 kB
        3. light_ok.png
          light_ok.png
          25 kB
        4. qtbug77006.zip
          2 kB
        5. styledark.qss
          43 kB
        6. stylelight.qss
          42 kB

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-79073 Cascading Stylesheet not updated (Regression from Qt 5.11)

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-75361 Widget Styles Missing

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-79545 StyleSheets are not set correctly

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-75810 Stylesheet does not propagate properly in some cases

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          resulted from

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-69204 QStyleSheetStyle updateObjects() can cause segmentation faults

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-77006
          # Subject Branch Project Status CR V
          272881,4 Ensure all children of a widget get updated when a stylesheet changes 5.13 qt/qtbase Status: MERGED +2 0
          275715,2 Ensure all children of a widget get updated when a stylesheet changes 5.12 qt/qtbase Status: MERGED +2 0

          Activity

            People

              frederik Frederik Gladhorn
              stvokr stvokr
              Votes:
              3 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes