Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-77238

Thread local storage (TLS) index leak on windows

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3: Somewhat important
    • Resolution: Done
    • Affects Version/s: 5.12.4, 5.13.0
    • Fix Version/s: 5.12.5, 5.14.0 Alpha
    • Component/s: Core: Threads
    • Labels:
      None
    • Platform/s:
      Windows
    • Commits:
      64d949207686a0225a78de572548a5361e340ae3 (qt/qtbase/5.12)

      Description

      qt_current_thread_data_tls_index is created by qt_create_tls() function.

      If qt_create_tls() is called by multiple threads at the same time, qt_current_thread_data_tls_index may be created multiple times, and only the last one is saved, the others are leaked.

      The code could be changed as follows.

      void qt_create_tls()
      {
       if (qt_current_thread_data_tls_index != TLS_OUT_OF_INDEXES)
         return;
       static QBasicMutex mutex;
       QMutexLocker locker(&mutex);
       if (qt_current_thread_data_tls_index != TLS_OUT_OF_INDEXES)
         return;
       qt_current_thread_data_tls_index = TlsAlloc();
      }

        Attachments

        For Gerrit Dashboard: QTBUG-77238
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            thiago Thiago Macieira
            Reporter:
            zhouyu Yu Zhou
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes