Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-77839 API Change Review for 5.14
  3. QTBUG-77857

QTextureDataUpdate API issues

    XMLWordPrintable

Details

    • Technical task
    • Status: Closed
    • Not Evaluated
    • Resolution: Done
    • 5.14.0 Alpha
    • Qt3D
    • None
    • c00976974549b6a1a047b2f2c680bcabdd7ccdb8 (qt/qt3d/5.14)

    Description

      The following have been identified:

      • op== should be non-member (friend, if needed), noexcept
      • op!= ditto, and inline, calling op==
      • consider using QExplicitlySharedDataPointer instead of unique_ptr as d-pointer
      • Q_DECLARE_TYPEINFO is missing
      • member and free swap() are missing
      • move assignment operator missing

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            mmutz Marc Mutz
            mmutz Marc Mutz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes